• snippet-service/config.yaml is excluded by !**/*.yaml
• snippet-service/pb/service.pb.go is excluded by !**/*.pb.go, !**/*.pb.go
• snippet-service/pb/service.pb.gw.go is excluded by !**/*.pb.gw.go, !**/*.pb.gw.go
• snippet-service/pb/service.swagger.json is excluded by !**/*.json
• snippet-service/pb/service_grpc.pb.go is excluded by !**/*.pb.go, !**/*.pb.go

• .github/workflows/build-publish.yaml (1 hunks)
• .golangci.yml (2 hunks)
• Makefile (1 hunks)
• bundle/Dockerfile (3 hunks)
• bundle/nginx/nginx.conf.template (1 hunks)
• bundle/run.sh (6 hunks)
• cloud2cloud-gateway/service/subscribeToDevices_test.go (2 hunks)
• cloud2cloud-gateway/test/events.go (1 hunks)
• snippet-service/Makefile (1 hunks)
• snippet-service/cmd/service/main.go (1 hunks)
• snippet-service/pb/README.md (1 hunks)
• snippet-service/pb/configuration.go (1 hunks)
• snippet-service/pb/doc.html (1 hunks)
• snippet-service/pb/service.proto (1 hunks)
• snippet-service/service/config.go (1 hunks)
• snippet-service/service/grpc/config.go (1 hunks)
• snippet-service/service/grpc/server.go (1 hunks)
• snippet-service/service/grpc/service.go (1 hunks)
• snippet-service/service/http/config.go (1 hunks)
• snippet-service/service/http/createConfiguration_test.go (1 hunks)
• snippet-service/service/http/getConfigurations_test.go (1 hunks)
• snippet-service/service/http/requestHandler.go (1 hunks)
• snippet-service/service/http/service.go (1 hunks)
• snippet-service/service/http/updateConfiguration_test.go (1 hunks)
• snippet-service/service/http/uri.go (1 hunks)
• snippet-service/service/service.go (1 hunks)
• snippet-service/service/service_test.go (1 hunks)
• snippet-service/store/condition.go (1 hunks)
• snippet-service/store/config/config.go (1 hunks)
• snippet-service/store/configuration.go (1 hunks)
• snippet-service/store/cqldb/config.go (1 hunks)
• snippet-service/store/cqldb/configuration.go (1 hunks)
• snippet-service/store/cqldb/store.go (1 hunks)
• snippet-service/store/mongodb/config.go (1 hunks)
• snippet-service/store/mongodb/configuration.go (1 hunks)
• snippet-service/store/mongodb/configuration_internal_test.go (1 hunks)
• snippet-service/store/mongodb/configuration_test.go (1 hunks)
• snippet-service/store/mongodb/store.go (1 hunks)
• snippet-service/store/store.go (1 hunks)
• snippet-service/test/configuration.go (1 hunks)
• snippet-service/test/service.go (1 hunks)
• snippet-service/test/test.go (1 hunks)
• test/config/config.go (1 hunks)
• test/http/request.go (1 hunks)
• test/http/uri.go (1 hunks)
• test/iotivity-lite/service/offboard_test.go (2 hunks)
• test/iotivity-lite/service/republish_test.go (1 hunks)

• snippet-service/pb/service.proto (no review received)
• bundle/Dockerfile (no review received)

• .golangci.yml
• Makefile
• cloud2cloud-gateway/test/events.go
• snippet-service/service/grpc/config.go
• snippet-service/service/http/uri.go
• snippet-service/service/service_test.go
• snippet-service/store/condition.go
• snippet-service/store/mongodb/config.go
• test/config/config.go

test/http/uri.go (1)

6-10: The addition of IDKey and ConfigurationIDKey aligns well with existing URI constants and supports the new functionality in snippet-service.

snippet-service/store/config/config.go (1)

1-9: The configuration type definition for integrating MongoDB and CQLDB is clear and follows good practices for structuring configurations in Go.

snippet-service/store/cqldb/config.go (1)

7-15: The configuration struct for CQLDB is well-defined, and the validation method is appropriately implemented.

snippet-service/service/http/config.go (1)

11-22: The HTTP configuration struct is robustly defined, and the validation method ensures all components are correctly configured.

snippet-service/pb/configuration.go (1)

12-25: The method for validating and normalizing Configuration objects is comprehensive, ensuring data integrity and consistency.

snippet-service/store/cqldb/configuration.go (1)

10-24: All CRUD operation methods in the CQLDB store return ErrNotSupported. Please verify if this is intentional and consider documenting the reason for these limitations to improve code clarity.

Would you like me to document these limitations in the code or open a GitHub issue to track this task?

snippet-service/store/configuration.go (3)

13-16: LGTM! The ConfigurationVersion struct is well-defined with appropriate BSON tags.

---

18-23: LGTM! The Configuration struct is well-defined with appropriate BSON tags.

---

25-31: LGTM! The MakeConfiguration function correctly initializes a Configuration instance from a protobuf message.

snippet-service/test/test.go (2)

13-19: LGTM! The CmpJSON function correctly compares JSON representations of objects.

---

35-42: LGTM! The CmpConfiguration function correctly compares configurations, handling resources separately.

snippet-service/store/mongodb/store.go (3)

19-21: The Store struct is correctly defined to embed the pkgMongo.Store. This allows leveraging existing MongoDB functionalities.

---

28-34: The creation of a unique index on _id and version is crucial for ensuring data integrity. This prevents duplicate configurations with the same version.

---

66-68: Simple and effective closure of the MongoDB store. It ensures that all resources are properly released.

test/iotivity-lite/service/republish_test.go (1)

48-48: The change from require.Greater to require.Positive is appropriate as it simplifies the assertion while ensuring that the count is above zero.

snippet-service/store/cqldb/store.go (1)

37-39: The Store struct is correctly defined to embed the cqldb.Store. This allows leveraging existing CQLDB functionalities.

snippet-service/store/store.go (2)

29-32: The Iterator interface is well-defined, providing a clear contract for iteration over collections.

---

69-79: The methods added to the Store interface for managing configurations are clear and concise. Ensure that the implementations of these methods handle errors appropriately and log significant events.

snippet-service/Makefile (2)

19-35: The build-docker-image definition is robust, incorporating dynamic tags and build arguments. Ensure that the Docker build context is correctly set to include all necessary files.

---

49-63: The proto/generate target is comprehensive, covering all necessary steps for generating protocol buffers, gRPC, and documentation. Ensure that all paths and dependencies are correctly configured to avoid build failures.

Verification successful

The paths for the googleapis directory and the service.proto file have been identified:

• dependency/googleapis/
• snippet-service/pb/service.proto

Let's verify the existence of these paths and files using the correct paths.

---

The necessary directories and files for the proto/generate target have been verified:

• The googleapis directory exists at dependency/googleapis/.
• The service.proto file exists at snippet-service/pb/service.proto.

This confirms that the paths and dependencies in the proto/generate target are correctly configured.

Scripts Executed

The following scripts were executed for the analysis:

---

Script:

#!/bin/bash
# Description: Verify that all paths and dependencies in the proto/generate target are correctly configured.

# Test: Check for the existence of necessary directories and files.
ls -l $(REPOSITORY_DIRECTORY)/dependency/googleapis $(REPOSITORY_DIRECTORY)/pb/service.proto

Length of output: 407

---

---

Script:

#!/bin/bash
# Description: Locate the necessary directories and files for the proto/generate target.

# Locate the googleapis directory
fd -t d googleapis

# Locate the service.proto file
fd -t f service.proto

Length of output: 273

---

---

Script:

#!/bin/bash
# Description: Verify the existence of necessary directories and files for the proto/generate target.

# Check for the existence of the googleapis directory
ls -l dependency/googleapis/

# Check for the existence of the service.proto file
ls -l snippet-service/pb/service.proto

Length of output: 162

snippet-service/test/service.go (4)

22-24: The HTTPURI function correctly constructs URIs for HTTP requests. This is a useful utility for tests that need to make network requests.

---

26-44: The MakeConfig function is well-implemented, setting up necessary configurations for testing. It's important to validate the configuration to catch any misconfigurations early.

---

46-73: The SetUp and New functions provide a clean way to set up and tear down the snippet-service for tests. The use of a sync.WaitGroup ensures that the service is properly shut down before the test exits.

---

75-97: The MakeStorageConfig function sets up storage configurations with options for MongoDB and CQLDB. Ensure that the configurations are tested to handle different storage scenarios effectively.

snippet-service/service/grpc/server.go (6)

25-33: Constructor implementation looks good and correctly initializes all fields.

---

36-44: Owner verification logic is correctly implemented to ensure security.

---

47-58: Method for creating configurations is well-implemented with appropriate error handling.

---

61-72: Update configuration method is correctly implemented with necessary owner checks and error handling.

---

75-102: Method for retrieving configurations is implemented correctly with streaming support and robust error handling.

---

105-107: Close method is simple and effective for cleaning up resources.

snippet-service/service/config.go (5)

18-39: Configuration struct and its validation method are correctly implemented, ensuring all fields are properly validated.

---

43-55: APIs configuration and validation are well-defined, ensuring both gRPC and HTTP configurations are validated.

---

58-67: HTTP configuration and its validation are properly implemented, ensuring the address is in a valid TCP format.

---

70-99: Storage configuration includes comprehensive validation, ensuring both embedded config and cleanup records are correctly formatted.

---

102-114: Clients configuration is well-structured with thorough validation for each client configuration.

snippet-service/store/mongodb/configuration_internal_test.go (1)

10-111: The test function for normalizing ID filters is well-implemented, covering various scenarios to ensure correct behavior.

.github/workflows/build-publish.yaml (1)

112-115: The GitHub Actions job for building and publishing the snippet-service image is correctly configured with appropriate directory and Dockerfile paths.

test/http/request.go (1)

105-111: The method ID in RequestBuilder is correctly implemented to add ID parameters to the URI. Consider enhancing the security of the TLS configuration.

- InsecureSkipVerify: true,
+ InsecureSkipVerify: true, MinVersion: tls.VersionTLS13

Likely invalid or redundant comment.

snippet-service/test/configuration.go (1)

22-29: Ensure consistent ID generation for configurations.

The function ConfigurationID ensures that each configuration ID is generated once and reused, which is crucial for consistency in tests that may rely on the ID being the same across different calls.

bundle/nginx/nginx.conf.template (1)

110-123: Ensure proper configuration for the new snippet service endpoint.

The configuration for the new /api/v1/snippets endpoint in the NGINX template is correctly set up to route traffic to the snippet service. This includes proper SSL configuration and CORS headers.

snippet-service/store/mongodb/configuration.go (1)

16-26: Ensure proper error handling for MongoDB operations.

Verification successful

---

The CreateConfiguration function in snippet-service/store/mongodb/configuration.go does handle errors returned by MongoDB operations. Specifically, it checks for errors after attempting to insert a document into the MongoDB collection and returns the error if one occurs.

• snippet-service/store/mongodb/configuration.go:16-26

The function includes proper error handling for the MongoDB InsertOne operation, returning any errors encountered during the insertion process.

Scripts Executed

The following scripts were executed for the analysis:

---

Script:

#!/bin/bash
# Description: Verify MongoDB error handling in the `CreateConfiguration` function.

# Test: Search for MongoDB error handling patterns. Expect: Proper error handling.
rg --type python $'CreateConfiguration'

Length of output: 69

---

---

Script:

#!/bin/bash
# Description: Verify MongoDB error handling in the `CreateConfiguration` function.

# Test: Search for the `CreateConfiguration` function in Go files and check for proper error handling.
rg --type go 'func (s \*Store) CreateConfiguration' -A 10

Length of output: 59

---

---

Script:

#!/bin/bash
# Description: Verify MongoDB error handling in the `CreateConfiguration` function.

# Test: Search for the `CreateConfiguration` function in Go files and check for proper error handling.
rg 'func (s \*Store) CreateConfiguration' -t go -A 20

Length of output: 55

---

---

Script:

#!/bin/bash
# Description: Verify MongoDB error handling in the `CreateConfiguration` function.

# Test: Search for the `CreateConfiguration` function across the entire repository and check for proper error handling.
rg 'CreateConfiguration' -A 20

Length of output: 60097

snippet-service/store/mongodb/configuration_test.go (3)

34-141: The function TestStoreCreateConfiguration is well-structured and covers a comprehensive set of test cases for configuration creation.

---

143-232: The function TestUpdateConfiguration effectively tests various scenarios for updating configurations, ensuring robust error handling and validation.

---

234-519: The function TestStoreGetConfigurations is well-implemented, testing a variety of retrieval scenarios and ensuring the correct configurations are fetched based on different filters.

test/iotivity-lite/service/offboard_test.go (2)

52-52: Changes from require.Greater to require.Positive are appropriate and make the assertions clearer.

Also applies to: 58-58

---

340-340: Change from require.Greater to require.Positive is appropriate and makes the assertion clearer.

bundle/run.sh (5)

27-28: Added environment variables for SNIPPET_SERVICE_ADDRESS and HTTP_SNIPPET_SERVICE_PORT are correctly set.

---

1315-1321: Monitor the snippet-service process to ensure it does not exit unexpectedly. Consider enhancing the monitoring logic to provide more detailed diagnostics in case of failure.

- ps aux |grep $snippet_service_pid |grep -q -v grep
- if [ $? -ne 0 ]; then
-   echo "snippet-service has already exited."
-   sync
-   cat $LOGS_PATH/snippet-service.log
-   exit 1
- fi
+ if ! ps -p $snippet_service_pid > /dev/null; then
+   echo "snippet-service has already exited."
+   sync
+   cat $LOGS_PATH/snippet-service.log
+   exit 1
+ fi

Likely invalid or redundant comment.

---

457-457: Ensure the HTTP_SNIPPET_SERVICE_PORT is defined and correctly replaced in the nginx configuration.

---

18-18: Ensure the environment variable HTTP_CERTIFICATE_AUTHORITY_PORT is defined.

Verification successful

---

The environment variable HTTP_CERTIFICATE_AUTHORITY_PORT is defined in the bundle/Dockerfile as ENV HTTP_CERTIFICATE_AUTHORITY_PORT=9090.

• bundle/Dockerfile: ENV HTTP_CERTIFICATE_AUTHORITY_PORT=9090

Scripts Executed

The following scripts were executed for the analysis:

---

Script:

#!/bin/bash
# Description: Verify if HTTP_CERTIFICATE_AUTHORITY_PORT is defined in the environment or configuration files.

# Test: Search for the definition of HTTP_CERTIFICATE_AUTHORITY_PORT. Expect: At least one occurrence.
rg --type bash 'HTTP_CERTIFICATE_AUTHORITY_PORT'

Length of output: 77

---

---

Script:

#!/bin/bash
# Description: Verify if HTTP_CERTIFICATE_AUTHORITY_PORT is defined in the environment or configuration files.

# Test: Search for the definition of HTTP_CERTIFICATE_AUTHORITY_PORT. Expect: At least one occurrence.
rg --type sh 'HTTP_CERTIFICATE_AUTHORITY_PORT'

Length of output: 276

---

---

Script:

#!/bin/bash
# Description: Verify if HTTP_CERTIFICATE_AUTHORITY_PORT is defined in common configuration files or environment setup scripts.

# Test: Search for the definition of HTTP_CERTIFICATE_AUTHORITY_PORT in .env, .bashrc, .bash_profile, and other shell scripts.
rg 'HTTP_CERTIFICATE_AUTHORITY_PORT' .env .bashrc .bash_profile
rg --type sh 'HTTP_CERTIFICATE_AUTHORITY_PORT'

Length of output: 487

---

---

Script:

#!/bin/bash
# Description: Verify if HTTP_CERTIFICATE_AUTHORITY_PORT is defined in any shell scripts or configuration files in the repository.

# Test: Search for the definition of HTTP_CERTIFICATE_AUTHORITY_PORT in all shell scripts and configuration files.
rg 'HTTP_CERTIFICATE_AUTHORITY_PORT'

Length of output: 459

---

1153-1185: The configuration and startup sequence for snippet-service is correctly implemented. Ensure that the configuration file /data/snippet-service.yaml is properly formatted and contains all necessary settings.

Files that changed from the base of the PR and between e438968 and 37b395c.

• charts/plgd-hub/templates/http-gateway/config.yaml is excluded by !**/*.yaml
• charts/plgd-hub/templates/snippet-service/config.yaml is excluded by !**/*.yaml
• charts/plgd-hub/templates/snippet-service/deployment.yaml is excluded by !**/*.yaml
• charts/plgd-hub/templates/snippet-service/domain-crt.yaml is excluded by !**/*.yaml
• charts/plgd-hub/templates/snippet-service/grpc-ingress.yaml is excluded by !**/*.yaml
• charts/plgd-hub/templates/snippet-service/grpc-service.yaml is excluded by !**/*.yaml
• charts/plgd-hub/templates/snippet-service/http-ingress.yaml is excluded by !**/*.yaml
• charts/plgd-hub/templates/snippet-service/http-service.yaml is excluded by !**/*.yaml
• charts/plgd-hub/templates/snippet-service/role.yaml is excluded by !**/*.yaml
• charts/plgd-hub/templates/snippet-service/service-account.yaml is excluded by !**/*.yaml
• charts/plgd-hub/templates/snippet-service/service-crt.yaml is excluded by !**/*.yaml
• charts/plgd-hub/values.yaml is excluded by !**/*.yaml
• go.mod is excluded by !**/*.mod
• go.sum is excluded by !**/*.sum, !**/*.sum
• grpc-gateway/pb/devices.pb.go is excluded by !**/*.pb.go, !**/*.pb.go
• grpc-gateway/pb/getPendingCommands.pb.go is excluded by !**/*.pb.go, !**/*.pb.go
• grpc-gateway/pb/hubConfiguration.pb.go is excluded by !**/*.pb.go, !**/*.pb.go
• grpc-gateway/pb/service.swagger.json is excluded by !**/*.json
• http-gateway/config.yaml is excluded by !**/*.yaml

• .github/workflows/build-publish.yaml (1 hunks)
• .github/workflows/test.yml (5 hunks)
• .vscode/settings.json (1 hunks)
• Makefile (7 hunks)
• bundle/Dockerfile (3 hunks)
• bundle/nginx/nginx.conf.template (1 hunks)
• bundle/run.sh (6 hunks)
• charts/plgd-hub/templates/http-gateway/_helpers.tpl (1 hunks)
• charts/plgd-hub/templates/snippet-service/_helpers.tpl (1 hunks)
• cloud2cloud-gateway/service/retrieveDevice.go (2 hunks)
• cloud2cloud-gateway/test/test.go (4 hunks)
• coap-gateway/service/clientObserveHandler.go (3 hunks)
• coap-gateway/service/clientSubscriber.go (1 hunks)
• coap-gateway/service/observation/deviceObserver.go (3 hunks)
• coap-gateway/service/resourceDirectory.go (1 hunks)
• coap-gateway/service/signIn.go (3 hunks)
• coap-gateway/test/test.go (1 hunks)
• grpc-gateway/client/client_test.go (2 hunks)
• grpc-gateway/client/createResource_test.go (2 hunks)
• grpc-gateway/client/deleteResource_test.go (3 hunks)
• grpc-gateway/client/deviceSubscriber.go (1 hunks)
• grpc-gateway/client/deviceSubscriptions_test.go (4 hunks)
• grpc-gateway/client/getDevice_test.go (2 hunks)
• grpc-gateway/client/getDevices_test.go (2 hunks)
• grpc-gateway/client/getResource_test.go (2 hunks)
• grpc-gateway/client/maintenance.go (2 hunks)
• grpc-gateway/client/maintenance_test.go (3 hunks)
• grpc-gateway/client/observeDeviceResources_test.go (2 hunks)
• grpc-gateway/client/observeDevices_test.go (2 hunks)
• grpc-gateway/client/observeResource_test.go (2 hunks)
• grpc-gateway/client/updateResource_test.go (3 hunks)
• grpc-gateway/pb/README.md (5 hunks)
• grpc-gateway/pb/createResource.go (2 hunks)
• grpc-gateway/pb/deleteResource.go (2 hunks)
• grpc-gateway/pb/devices.proto (3 hunks)
• grpc-gateway/pb/doc.html (5 hunks)
• grpc-gateway/pb/getPendingCommands.proto (1 hunks)
• grpc-gateway/pb/hubConfiguration.proto (1 hunks)
• grpc-gateway/pb/updateResource.go (2 hunks)
• grpc-gateway/service/createResource.go (1 hunks)
• grpc-gateway/service/deleteResource.go (1 hunks)
• grpc-gateway/service/subscribeToEvents_test.go (4 hunks)
• grpc-gateway/service/updateResource.go (1 hunks)
• grpc-gateway/service/updateResource_test.go (2 hunks)
• grpc-gateway/test/test.go (1 hunks)
• http-gateway/service/config.go (1 hunks)
• http-gateway/service/getDevicePendingCommands_test.go (2 hunks)
• http-gateway/service/getDeviceResourceLinks_test.go (3 hunks)
• http-gateway/service/getHubConfiguration.go (1 hunks)
• http-gateway/service/getHubConfiguration_test.go (2 hunks)
• http-gateway/service/getPendingCommands_test.go (2 hunks)
• http-gateway/service/getResourcePendingCommands_test.go (2 hunks)
• http-gateway/test/test.go (2 hunks)
• http-gateway/uri/uri.go (2 hunks)

• .vscode/settings.json

grpc-gateway/service/deleteResource.go (1)

10-18: Verify correctness of handleResourceRequest parameters.

Ensure that the parameters passed to handleResourceRequest are correct and match the expected types and values.

grpc-gateway/service/updateResource.go (1)

10-18: Verify correctness of handleResourceRequest parameters.

Ensure that the parameters passed to handleResourceRequest are correct and match the expected types and values.

Verification successful

---

The parameters passed to handleResourceRequest in the UpdateResource function are correct.

• The parameters align with the expected types and values of the handleResourceRequest function.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the parameters passed to `handleResourceRequest` in `UpdateResource`.

# Test: Search for the `handleResourceRequest` function definition. Expect: Correct parameter types and values.
rg --type go 'func handleResourceRequest'

Length of output: 173

---

Script:

#!/bin/bash
# Description: Extract the `UpdateResource` function definition and check parameters passed to `handleResourceRequest`.

# Find the `UpdateResource` function in `grpc-gateway/service/updateResource.go`.
rg --type go --pcre2 'func UpdateResource' -A 20 grpc-gateway/service/updateResource.go

Length of output: 89

---

Script:

#!/bin/bash
# Description: Search for the `UpdateResource` function definition in the entire codebase and check parameters passed to `handleResourceRequest`.

# Find the `UpdateResource` function in the entire codebase.
rg --type go --pcre2 'func UpdateResource' -A 20

Length of output: 50

---

Script:

#!/bin/bash
# Description: Search for all `handleResourceRequest` calls in the codebase to identify where it is being used.

# Find all calls to `handleResourceRequest` in the codebase.
rg --type go 'handleResourceRequest'

Length of output: 397

---

Script:

#!/bin/bash
# Description: Extract more lines around the `handleResourceRequest` call in `grpc-gateway/service/updateResource.go` to identify the `UpdateResource` function and its parameters.

# Extract lines around the `handleResourceRequest` call in `grpc-gateway/service/updateResource.go`.
rg --type go 'handleResourceRequest' -A 10 -B 10 grpc-gateway/service/updateResource.go

Length of output: 510

coap-gateway/service/clientSubscriber.go (3)

14-18: LGTM!

The function is correctly structured and thread-safe.

---

20-25: LGTM!

The function is correctly structured and ensures that the deviceSubscriber is not nil before calling the method.

---

Line range hint 26-34:
LGTM!

The function is correctly structured and ensures proper cleanup of the deviceSubscriber.

grpc-gateway/pb/deleteResource.go (2)

Line range hint 8-34:
LGTM!

The function is correctly structured and includes the new Force field.

---

38-43: LGTM!

The function is correctly structured and ensures that the response object is not nil before setting the Data field.

grpc-gateway/pb/createResource.go (2)

39-39: LGTM!

The addition of the Force field is consistent with the rest of the function.

---

43-48: LGTM!

The SetData function correctly sets the Data field and handles the case where the receiver is nil.

grpc-gateway/pb/updateResource.go (2)

40-40: LGTM!

The addition of the Force field is consistent with the rest of the function.

---

44-49: LGTM!

The SetData function correctly sets the Data field and handles the case where the receiver is nil.

grpc-gateway/pb/getPendingCommands.proto (1)

23-23: LGTM!

The addition of the include_hidden_resources field to the GetPendingCommandsRequest message is consistent with the rest of the message structure.

charts/plgd-hub/templates/snippet-service/_helpers.tpl (7)

1-12: LGTM!

The template plgd-hub.snippetservice.fullname correctly handles the full name based on various conditions.

---

14-17: LGTM!

The template plgd-hub.snippetservice.configName correctly generates the configuration name based on the full name.

---

19-26: LGTM!

The template plgd-hub.snippetservice.createServiceCertByCm correctly handles the creation of the service certificate based on the presence of the tls.certFile.

---

28-34: LGTM!

The template plgd-hub.snippetservice.domain correctly generates the domain based on the presence of the snippetservice.domain value.

---

36-39: LGTM!

The template plgd-hub.snippetservice.serviceCertName correctly generates the service certificate name based on the full name.

---

41-48: LGTM!

The template plgd-hub.snippetservice.domainCertName correctly generates the domain certificate name based on the presence of the ingress.secretName.

---

50-53: LGTM!

The template plgd-hub.snippetservice.selectorLabels correctly generates the selector labels based on the snippetservice.name and Release.Name.

grpc-gateway/service/createResource.go (6)

13-14: LGTM!

The resourceError function is correctly implemented.

---

17-19: LGTM!

The reqRACommand type constraint is correctly defined.

---

21-23: LGTM!

The respCommand type constraint is correctly defined.

---

25-28: LGTM!

The reqCommand type constraint is correctly defined.

---

35-69: Verify the use of * as the owner in the synchronous call.

The use of * as the owner in the synchronous call to syncFunc might need verification to ensure it is intended and correct.

---

71-80: LGTM!

The CreateResource function is correctly implemented.

grpc-gateway/test/test.go (2)

20-34: LGTM!

The NewTestClient function is correctly implemented.

---

Line range hint 35-58: LGTM!

The MakeConfig function is correctly implemented.

grpc-gateway/client/observeDeviceResources_test.go (4)

29-31: Ensure the client is properly closed.

The client is properly closed using defer and error handling is done using require.NoError.

---

Line range hint 32-32:
Ensure the test logic remains intact.

The test logic remains intact, ensuring that device resources are observed correctly.

---

9-9: Verify the new import.

The new import grpcgwTest should be verified for correctness and consistency with the rest of the codebase.

Verification successful

---

The new import is verified and consistent.

The import grpcgwTest "github.com/plgd-dev/hub/v2/grpc-gateway/test" is consistently used across multiple test files in the codebase, indicating it is correct and properly integrated.

• snippet-service/service/service_test.go
• snippet-service/service/http/invokeConfiguration_test.go
• snippet-service/updater/resourceUpdater_test.go
• test/service/service.go
• grpc-gateway/client/observeResource_test.go
• grpc-gateway/client/createResource_test.go
• grpc-gateway/client/observeDevices_test.go
• grpc-gateway/client/updateResource_test.go
• grpc-gateway/client/getDevices_test.go
• grpc-gateway/client/getDevice_test.go
• grpc-gateway/client/deleteResource_test.go
• grpc-gateway/client/getResource_test.go
• grpc-gateway/client/maintenance_test.go
• grpc-gateway/client/observeDeviceResources_test.go
• grpc-gateway/client/deviceSubscriptions_test.go

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the import `grpcgwTest` is consistent with the codebase.

# Test: Search for the import usage. Expect: Consistent usage across the codebase.
rg --type go 'grpcgwTest "github.com/plgd-dev/hub/v2/grpc-gateway/test"'

Length of output: 1600

---

28-28: Verify the usage of grpcgwTest.NewTestClient.

Ensure that the usage of grpcgwTest.NewTestClient is correct and efficient.

Verification successful

---

The implementation of grpcgwTest.NewTestClient in grpc-gateway/test/test.go appears to be correct and efficient. The function sets up a test client with proper TLS configuration and error handling.

• Correctness: The function correctly configures the TLS settings and creates a new client from the configuration. It ensures that there are no errors during the client creation process.
• Efficiency: The function does not contain any redundant or inefficient operations.

No changes are necessary.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the usage of `grpcgwTest.NewTestClient`.

# Test: Search for the usage of `grpcgwTest.NewTestClient`. Expect: Correct and efficient usage.
rg --type go 'grpcgwTest.NewTestClient'

Length of output: 1651

---

Script:

#!/bin/bash
# Searching for the implementation of `NewTestClient` in the `grpcgwTest` package.
ast-grep --lang go --pattern 'func NewTestClient($_) $_' 

Length of output: 900

grpc-gateway/client/maintenance.go (3)

69-69: Ensure the logic for updating maintenance resources remains intact.

The logic for updating maintenance resources remains intact, ensuring that the correct resource is updated based on the device ID and resource type.

---

6-6: Verify the new import.

The new import slices should be verified for correctness and consistency with the rest of the codebase.

Verification successful

---

The new import slices is correctly and consistently used across the codebase.

• grpc-gateway/client/maintenance.go: Verified usage of slices.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the import `slices` is consistent with the codebase.

# Test: Search for the import usage. Expect: Consistent usage across the codebase.
rg --type go 'slices'

Length of output: 5685

---

68-68: Verify the usage of slices.Contains.

Ensure that the usage of slices.Contains is correct and efficient for checking resource types.

Verification successful

---

The usage of slices.Contains is correct.

The method r.GetResourceTypes() returns a slice of strings ([]string), and maintenance.ResourceType is a string. Therefore, using slices.Contains to check if maintenance.ResourceType is in the slice returned by r.GetResourceTypes() is both correct and efficient.

• grpc-gateway/client/maintenance.go:68

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the usage of `slices.Contains`.

# Test: Search for the usage of `slices.Contains`. Expect: Correct and efficient usage.
rg --type go 'slices.Contains'

Length of output: 1267

---

Script:

#!/bin/bash
# Verify the implementation of `r.GetResourceTypes()` and the definition of `maintenance.ResourceType`.

# Find all Go files and search for the implementation of `GetResourceTypes` method.
rg --type go 'func (.*) GetResourceTypes' 

# Find the definition of `maintenance.ResourceType`.
rg --type go 'ResourceType' 

Length of output: 72267

grpc-gateway/client/getDevices_test.go (4)

74-76: Ensure the client is properly closed.

The client is properly closed using defer and error handling is done using require.NoError.

---

Line range hint 77-77:
Ensure the test logic remains intact.

The test logic remains intact, ensuring that devices are retrieved correctly.

---

9-9: Verify the new import.

The new import grpcgwTest should be verified for correctness and consistency with the rest of the codebase.

Verification successful

---

Verified the new import.

The import statement grpcgwTest "github.com/plgd-dev/hub/v2/grpc-gateway/test" is consistently used across multiple test files in the codebase, indicating correctness.

• Files with the same import:
  • snippet-service/service/service_test.go
  • snippet-service/updater/resourceUpdater_test.go
  • snippet-service/service/http/invokeConfiguration_test.go
  • test/service/service.go
  • grpc-gateway/client/deviceSubscriptions_test.go
  • grpc-gateway/client/maintenance_test.go
  • grpc-gateway/client/observeDevices_test.go
  • grpc-gateway/client/observeResource_test.go
  • grpc-gateway/client/getDevices_test.go
  • grpc-gateway/client/getDevice_test.go
  • grpc-gateway/client/observeDeviceResources_test.go
  • grpc-gateway/client/deleteResource_test.go
  • grpc-gateway/client/createResource_test.go
  • grpc-gateway/client/getResource_test.go
  • grpc-gateway/client/updateResource_test.go

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the import `grpcgwTest` is consistent with the codebase.

# Test: Search for the import usage. Expect: Consistent usage across the codebase.
rg --type go 'grpcgwTest "github.com/plgd-dev/hub/v2/grpc-gateway/test"'

Length of output: 1600

---

73-73: Verify the usage of grpcgwTest.NewTestClient.

Ensure that the usage of grpcgwTest.NewTestClient is correct and efficient.

Verification successful

---

Verified the usage of grpcgwTest.NewTestClient.

The usage of grpcgwTest.NewTestClient in the test files is correct and efficient. The client is created, used appropriately, and closed with error handling, ensuring proper resource management.

• No changes needed.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the usage of `grpcgwTest.NewTestClient`.

# Test: Search for the usage of `grpcgwTest.NewTestClient`. Expect: Correct and efficient usage.
rg --type go 'grpcgwTest.NewTestClient'

Length of output: 1651

---

Script:

#!/bin/bash
# Locate the definition of `grpcgwTest.NewTestClient` to understand its implementation.
ast-grep --lang go --pattern 'func NewTestClient($_) $_' --json

Length of output: 1169

---

Script:

#!/bin/bash
# Check the context of `grpcgwTest.NewTestClient` usage in the test files to ensure correct and efficient usage.
rg --type go -A 5 'grpcgwTest.NewTestClient'

Length of output: 10094

grpc-gateway/client/observeDevices_test.go (4)

28-30: Ensure the client is properly closed.

The client is properly closed using defer and error handling is done using require.NoError.

---

Line range hint 31-31:
Ensure the test logic remains intact.

The test logic remains intact, ensuring that devices are observed correctly.

---

10-10: Verify the new import.

The new import grpcgwTest should be verified for correctness and consistency with the rest of the codebase.

Verification successful

---

The new import is verified for correctness and consistency.

The import grpcgwTest "github.com/plgd-dev/hub/v2/grpc-gateway/test" is consistently used across various test files in the codebase, primarily to create test clients and configure GRPC gateway settings.

• snippet-service/updater/resourceUpdater_test.go
• snippet-service/service/service_test.go
• snippet-service/service/http/invokeConfiguration_test.go
• test/service/service.go
• grpc-gateway/client/getDevices_test.go
• grpc-gateway/client/deleteResource_test.go
• grpc-gateway/client/observeDevices_test.go
• grpc-gateway/client/observeResource_test.go
• grpc-gateway/client/getResource_test.go
• grpc-gateway/client/getDevice_test.go
• grpc-gateway/client/maintenance_test.go
• grpc-gateway/client/deviceSubscriptions_test.go
• grpc-gateway/client/observeDeviceResources_test.go
• grpc-gateway/client/createResource_test.go
• grpc-gateway/client/updateResource_test.go

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the import `grpcgwTest` is consistent with the codebase.

# Test: Search for the import usage. Expect: Consistent usage across the codebase.
rg --type go 'grpcgwTest "github.com/plgd-dev/hub/v2/grpc-gateway/test"'

Length of output: 1600

---

Script:

#!/bin/bash
# Description: Verify the usage of the imported `grpcgwTest` in the files where it is imported.

# Test: Search for `grpcgwTest` usage in the relevant test files.
files=(
    "snippet-service/updater/resourceUpdater_test.go"
    "snippet-service/service/service_test.go"
    "snippet-service/service/http/invokeConfiguration_test.go"
    "test/service/service.go"
    "grpc-gateway/client/getDevices_test.go"
    "grpc-gateway/client/deleteResource_test.go"
    "grpc-gateway/client/observeDevices_test.go"
    "grpc-gateway/client/observeResource_test.go"
    "grpc-gateway/client/getResource_test.go"
    "grpc-gateway/client/getDevice_test.go"
    "grpc-gateway/client/maintenance_test.go"
    "grpc-gateway/client/deviceSubscriptions_test.go"
    "grpc-gateway/client/observeDeviceResources_test.go"
    "grpc-gateway/client/createResource_test.go"
    "grpc-gateway/client/updateResource_test.go"
)

for file in "${files[@]}"; do
    echo "Checking usage in $file"
    rg 'grpcgwTest' "$file"
done

Length of output: 5715

---

27-27: Verify the usage of grpcgwTest.NewTestClient.

Ensure that the usage of grpcgwTest.NewTestClient is correct and efficient.

Verification successful

---

The usage of grpcgwTest.NewTestClient is correct and efficient.

• The function NewTestClient is correctly implemented in grpc-gateway/test/test.go.
• The import statement for grpcgwTest in grpc-gateway/client/observeDevices_test.go is correct.
• The client is properly initialized and closed in the test file.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the usage of `grpcgwTest.NewTestClient`.

# Test: Search for the usage of `grpcgwTest.NewTestClient`. Expect: Correct and efficient usage.
rg --type go 'grpcgwTest.NewTestClient'

Length of output: 1651

---

Script:

#!/bin/bash
# Locate the implementation of `NewTestClient` to understand its functionality.
ast-grep --lang go --pattern 'func NewTestClient($_) $_' 

# Check the imports in the test files to ensure `grpcgwTest` is properly imported.
rg --type go 'import' -A 5 -B 5 grpc-gateway/client/observeDevices_test.go

Length of output: 1045

---

Script:

#!/bin/bash
# Check the imports in the test files to ensure `grpcgwTest` is properly imported.
rg --type go 'grpcgwTest' -A 5 -B 5 grpc-gateway/client/observeDevices_test.go

Length of output: 882

grpc-gateway/pb/hubConfiguration.proto (1)

61-62: LGTM!

The addition of the snippet_service field to the UIConfiguration message is well-documented and follows the existing pattern.

grpc-gateway/client/maintenance_test.go (2)

54-56: LGTM!

The usage of grpcgwTest.NewTestClient in TestClientFactoryReset is correct and follows the existing pattern in the file.

---

108-110: LGTM!

The usage of grpcgwTest.NewTestClient in TestClientReboot is correct and follows the existing pattern in the file.

http-gateway/test/test.go (2)

24-24: LGTM!

The addition of the SnippetService field to the MakeWebConfigurationConfig function is well-documented and follows the existing pattern.

---

55-55: LGTM!

The modification of the MakeConfig function to use config.MakeValidatorConfig for the Authorization field is correct and follows the existing pattern.

cloud2cloud-gateway/test/test.go (1)

7-7: LGTM!

The usage of the slices package in the GetUniqueSubscriptionID function is correct and follows the existing pattern.

grpc-gateway/client/getResource_test.go (2)

11-11: Import statement approved.

The import statement for grpcgwTest is correctly added.

---

Line range hint 104-108: Test client instantiation approved.

The new test client is correctly instantiated using grpcgwTest.NewTestClient(t) and properly closed after use.

http-gateway/service/getHubConfiguration.go (1)

78-78: Addition of SnippetService field approved.

The new field SnippetService is correctly added to the UIConfiguration and assigned from the requestHandler.config.UI.WebConfiguration.SnippetService.

charts/plgd-hub/templates/http-gateway/_helpers.tpl (1)

86-98: Addition of snippetServiceApiDomain template definition approved.

The new template definition for snippetServiceApiDomain is correctly added and follows the existing structure of the file.

coap-gateway/test/test.go (1)

55-55: Verify the new assignment for Authority.

Ensure that config.MakeValidatorConfig() is the correct function to use for the Authority field and that it matches the expected configuration.

grpc-gateway/client/getDevice_test.go (1)

96-96: Verify the new test client instantiation.

Ensure that grpcgwTest.NewTestClient(t) correctly initializes the test client and integrates well with the existing test logic.

http-gateway/service/getDeviceResourceLinks_test.go (1)

103-104: Verify the new typeFilter logic.

Ensure that the new typeFilter logic using slices.Contains correctly filters the resource links and integrates well with the existing test logic.

http-gateway/service/getHubConfiguration_test.go (2)

33-33: Verify the new SnippetService field addition.

Ensure that the new SnippetService field is correctly added to the expected configuration and integrates well with the existing test logic.

---

89-89: Verify the new SnippetService field addition.

Ensure that the new SnippetService field is correctly added to the expected configuration and integrates well with the existing test logic.

grpc-gateway/client/updateResource_test.go (3)

11-11: Review the new test client instantiation.

The new test client instantiation method grpcgwTest.NewTestClient(t) is introduced. Ensure that this updated method is correctly used and integrates well with the existing tests.

---

98-98: Ensure proper cleanup of the test client.

The test client c is instantiated using grpcgwTest.NewTestClient(t). Ensure that the client is properly closed to avoid resource leaks.

---

135-135: Ensure proper cleanup of the test client.

The test client c is instantiated using grpcgwTest.NewTestClient(t). Ensure that the client is properly closed to avoid resource leaks.

.github/workflows/build-publish.yaml (1)

112-115: Review the new job for snippet-service.

The new job for snippet-service is added with the directory snippet-service, Dockerfile .tmp/docker/snippet-service/Dockerfile, and template file tools/docker/Dockerfile.in. Ensure that the configurations are correct and the job integrates well within the CI/CD pipeline.

grpc-gateway/client/deleteResource_test.go (3)

13-13: Review the new test client instantiation.

The new test client instantiation method grpcgwTest.NewTestClient(t) is introduced. Ensure that this updated method is correctly used and integrates well with the existing tests.

---

87-87: Ensure proper cleanup of the test client.

The test client c is instantiated using grpcgwTest.NewTestClient(t). Ensure that the client is properly closed to avoid resource leaks.

---

176-176: Ensure proper cleanup of the test client.

The test client c is instantiated using grpcgwTest.NewTestClient(t). Ensure that the client is properly closed to avoid resource leaks.

.github/workflows/test.yml (2)

87-90: Review the new logging configurations for snippet-service.

The new logging configurations for snippet-service are added. Ensure that the configurations are correct and integrate well within the CI/CD pipeline.

---

119-119: Review the new logging configurations for snippet-service.

The new logging configurations for snippet-service are added. Ensure that the configurations are correct and integrate well within the CI/CD pipeline.

cloud2cloud-gateway/service/retrieveDevice.go (1)

77-80: LGTM!

The update to use commands.DecodeContent enhances maintainability and consistency.

http-gateway/service/getResourcePendingCommands_test.go (3)

168-178: LGTM!

The addition of new test cases and helper functions improves test coverage and robustness.

---

191-201: LGTM!

The addition of new test cases and helper functions improves test coverage and robustness.

---

205-209: LGTM!

The addition of new test cases and helper functions improves test coverage and robustness.

http-gateway/uri/uri.go (1)

25-26: LGTM!

The additions of IncludeHiddenResourcesQueryKey and ForceQueryKey are consistent with existing constants.

http-gateway/service/config.go (1)

196-196: LGTM!

The addition of the SnippetService field to WebConfiguration is consistent with existing fields.

bundle/nginx/nginx.conf.template (1)

124-137: Ensure the REPLACE_HTTP_SNIPPET_SERVICE_PORT is properly set.

The new location block for snippet-service appears correct, but it is crucial to ensure that REPLACE_HTTP_SNIPPET_SERVICE_PORT is properly set during deployment to avoid runtime issues.

coap-gateway/service/resourceDirectory.go (1)

176-177: Verify the triggerDeviceSubscriber method implementation.

The addition of client.triggerDeviceSubscriber() seems to trigger pending commands for published resources. Ensure that this method is correctly implemented and does not introduce side effects.

grpc-gateway/pb/devices.proto (3)

70-71: Fields force and async added to UpdateResourceRequest.

The fields force and async have been added to UpdateResourceRequest. Ensure that these fields are properly handled in the service logic.

---

225-226: Fields force and async added to DeleteResourceRequest.

The fields force and async have been added to DeleteResourceRequest. Ensure that these fields are properly handled in the service logic.

---

237-238: Fields force and async added to CreateResourceRequest.

The fields force and async have been added to CreateResourceRequest. Ensure that these fields are properly handled in the service logic.

coap-gateway/service/clientObserveHandler.go (2)

9-9: Ensure compatibility with slices package.

The slices package has been imported. Ensure that the Go version and environment support this package.

---

122-122: Usage of slices.Contains in isDuplicateEvent method.

The slices.Contains method is used to check if the event's href is in the list of unpublished resources. This is a correct and efficient usage.

http-gateway/service/getDevicePendingCommands_test.go (3)

256-266: Ensure correct error assertion.

In the createFn function, the error assertion is correct. However, ensure that the errC variable is properly checked for context-specific error messages if needed.

---

279-289: Ensure correct error assertion.

In the updateFn function, the error assertion is correct. However, ensure that the errU variable is properly checked for context-specific error messages if needed.

---

293-297: Ensure correct error assertion.

In the deleteFn function, the error assertion is correct. However, ensure that the errD variable is properly checked for context-specific error messages if needed.

http-gateway/service/getPendingCommands_test.go (3)

303-313: Ensure correct error assertion.

In the createFn function, the error assertion is correct. However, ensure that the errC variable is properly checked for context-specific error messages if needed.

---

326-336: Ensure correct error assertion.

In the updateFn function, the error assertion is correct. However, ensure that the errU variable is properly checked for context-specific error messages if needed.

---

340-344: Ensure correct error assertion.

In the deleteFn function, the error assertion is correct. However, ensure that the errD variable is properly checked for context-specific error messages if needed.

coap-gateway/service/signIn.go (2)

7-7: Ensure the slices import is necessary.

The slices package is imported, but ensure that it is used appropriately in the code.

---

176-176: Ensure efficient usage of slices.Contains.

The slices.Contains function is used to check if the device ID is in the list of device IDs. Ensure that this function is used correctly and efficiently.

bundle/Dockerfile (3)

116-122: Ensure correct build steps for snippet-service.

The build steps for the snippet-service are added. Ensure that the build steps are correct and follow best practices.

---

188-189: Ensure correct steps for copying snippet-service binaries and configuration.

The steps for copying the snippet-service binaries and configuration are added. Ensure that the steps are correct and follow best practices.

---

244-245: Ensure correct environment variable definitions for snippet-service.

The environment variables for the snippet-service are added. Ensure that the environment variables are correctly defined and used.

grpc-gateway/client/deviceSubscriptions_test.go (4)

12-12: Import statement approved.

The import statement adds a new alias grpcgwTest for the grpc-gateway/test package, which is used to instantiate a new test client.

---

86-88: Test client instance usage approved.

The new test client instance is created and closed properly in TestObserveDeviceResourcesRetrieve.

---

181-183: Test client instance usage approved.

The new test client instance is created and closed properly in TestObserveDeviceResourcesUpdate.

---

310-312: Test client instance usage approved.

The new test client instance is created and closed properly in TestObserveDeviceResourcesCreateAndDelete.

grpc-gateway/client/deviceSubscriber.go (1)

269-275: New method TriggerGetPendingCommands approved.

The new method triggers a reconnect by sending to the reconnectChan channel, which is implemented correctly.

coap-gateway/service/observation/deviceObserver.go (2)

9-9: Usage of slices package approved.

The slices package is used to check if a slice contains a specific element, which is implemented correctly.

---

311-311: Method IsDiscoveryResourceObservable approved.

The method uses slices.Contains to check if the Interfaces slice contains observeInterface, which is implemented correctly.

Makefile (7)

34-35: New logging configurations for snippet-service approved.

The new logging configurations TEST_SNIPPET_SERVICE_LOG_LEVEL and TEST_SNIPPET_SERVICE_LOG_DUMP_BODY are added correctly.

---

47-47: Addition of snippet-service to SUBDIRS list approved.

The snippet-service is added to the SUBDIRS list correctly.

---

332-334: Modification of RUN-TESTS-IN-DIRECTORY macro approved.

The macro is modified to run tests with additional shell command, which is implemented correctly.

---

377-377: Modification of RUN-TESTS-UDP macro approved.

The macro is modified to include new logging configurations for snippet-service, which is implemented correctly.

Also applies to: 385-385

---

398-398: Modification of test target approved.

The test target is modified to include new logging configurations for snippet-service, which is implemented correctly.

---

419-419: Modification of test/mem target approved.

The test/mem target is modified to include new logging configurations for snippet-service, which is implemented correctly.

---

437-444: Modification of RUN-TESTS-IN-DIRECTORY macro approved.

The macro is modified to include new logging configurations for snippet-service, which is implemented correctly.

grpc-gateway/service/updateResource_test.go (1)

418-652: LGTM!

The new test method TestUpdateCreateOnNotExistingResource is well-structured and follows the pattern of other test methods in the file. It correctly handles the context and connection setup and teardown. The test cases cover various scenarios for updating and creating resources.

grpc-gateway/service/subscribeToEvents_test.go (1)

Line range hint 670-721:
LGTM!

The new test method TestRequestHandlerSubscribeForPendingCommands is well-structured and follows the pattern of other test methods in the file. It correctly handles the context and connection setup and teardown. The test cases cover various scenarios for subscribing to pending commands.

bundle/run.sh (5)

27-28: Ensure the new environment variables are used correctly.

The new environment variables SNIPPET_SERVICE_ADDRESS and SNIPPET_SERVICE_HTTP_ADDRESS are exported correctly. Verify their usage in the codebase to ensure they're being utilized as expected.

Verification successful

---

The new environment variables SNIPPET_SERVICE_ADDRESS and SNIPPET_SERVICE_HTTP_ADDRESS are used correctly in the codebase.

The variables are utilized appropriately within bundle/run.sh:

• SNIPPET_SERVICE_ADDRESS is used for gRPC address configuration and connection checks.

• SNIPPET_SERVICE_HTTP_ADDRESS is used for HTTP address configuration.

• bundle/run.sh:

  • Line 27: export SNIPPET_SERVICE_ADDRESS="localhost:${SNIPPET_SERVICE_PORT}"
  • Line 28: export SNIPPET_SERVICE_HTTP_ADDRESS="localhost:${HTTP_SNIPPET_SERVICE_PORT}"
  • Usage in gRPC and HTTP address settings and connection checks.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the usage of `SNIPPET_SERVICE_ADDRESS` and `SNIPPET_SERVICE_HTTP_ADDRESS` in the codebase.

# Test: Search for the environment variables usage. Expect: Proper usage in the codebase.
rg --type sh $'SNIPPET_SERVICE_ADDRESS'
rg --type sh $'SNIPPET_SERVICE_HTTP_ADDRESS'

Length of output: 720

---

18-18: Ensure the new environment variable is used correctly.

The new environment variable CERTIFICATE_AUTHORITY_HTTP_ADDRESS is exported correctly. Verify its usage in the codebase to ensure it's being utilized as expected.

Verification successful

---

The new environment variable is used correctly.

The CERTIFICATE_AUTHORITY_HTTP_ADDRESS is correctly exported and utilized within the codebase, particularly in the certificate-authority/config.yaml file.

• bundle/run.sh: Line 18 - Export statement.
• charts/plgd-hub/templates/certificate-authority/config.yaml: Usage in configuration.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the usage of `CERTIFICATE_AUTHORITY_HTTP_ADDRESS` in the codebase.

# Test: Search for the environment variable usage. Expect: Proper usage in the codebase.
rg --type sh $'CERTIFICATE_AUTHORITY_HTTP_ADDRESS'

Length of output: 233

---

Script:

#!/bin/bash
# Description: Verify the usage of `.apis.http.address` in the codebase.

# Test: Search for the usage of `.apis.http.address`. Expect: Proper usage in the codebase.
rg --type sh $'.apis.http.address'

Length of output: 549

---

Script:

#!/bin/bash
# Description: Verify the usage of `.apis.http.address` in the codebase beyond assignments.

# Test: Search for the usage of `.apis.http.address` in the codebase. Expect: Proper usage in the codebase.
rg '.apis.http.address'

Length of output: 1268

---

1250-1293: Ensure the snippet-service configuration and startup commands are correct.

The configuration and startup commands for the snippet-service are consistent with other services. Verify that the configuration file is correctly generated and the service starts as expected.

---

1419-1425: Ensure the process check for snippet-service is correct.

The process check for snippet-service is consistent with other similar checks. Verify that the process ID is correctly monitored and the service status is logged as expected.

---

490-490: Ensure the sed command correctly replaces the placeholder.

The sed command to replace REPLACE_HTTP_SNIPPET_SERVICE_PORT is consistent with other similar commands. Verify that the placeholder is correctly replaced in the nginx configuration.

grpc-gateway/pb/README.md (1)

914-914: Add missing commas and fix double punctuation.

Add a comma before "and" to connect independent clauses and remove the double punctuation at the end of the sentence.

-  | resource_id_filter | [ResourceIdFilter](#grpcgateway-pb-ResourceIdFilter) | repeated | New resource ID filter. For HTTP requests, use it multiple times as a query parameter like "resourceIdFilter={deviceID}{href}". |
+  | resource_id_filter | [ResourceIdFilter](#grpcgateway-pb-ResourceIdFilter) | repeated | New resource ID filter. For HTTP requests, use it multiple times as a query parameter like "resourceIdFilter={deviceID}{href}." |
-  | include_hidden_resources | [bool](#bool) |  | Get all pending commands for all resources, even if the resource is not published. |
+  | include_hidden_resources | [bool](#bool) |  | Get all pending commands for all resources, even if the resource is not published. |

Likely invalid or redundant comment.

grpc-gateway/pb/doc.html (5)

844-857: New fields added to CreateResourceRequest.

The fields force and async enhance the functionality of the CreateResourceRequest. These additions look good.

---

968-981: New fields added to DeleteResourceRequest.

The fields force and async enhance the functionality of the DeleteResourceRequest. These additions look good.

---

1982-1995: New fields added to UpdateResourceRequest.

The fields force and async enhance the functionality of the UpdateResourceRequest. These additions look good.

---

2528-2533: New field added to GetPendingCommandsRequest.

The field include_hidden_resources enhances the functionality of the GetPendingCommandsRequest by allowing the retrieval of all pending commands for all resources, even if the resource is not published. This addition looks good.

---

2941-2946: New field added to UIConfiguration.

The field snippet_service enhances the UIConfiguration by providing the address to the snippet service HTTP API. This addition looks good.

Files that changed from the base of the PR and between 37b395c and 0dfa3f3.

• charts/plgd-hub/values.yaml is excluded by !**/*.yaml
• snippet-service/config.yaml is excluded by !**/*.yaml

• snippet-service/service/grpc/server.go (1 hunks)
• snippet-service/service/http/deleteAppliedConfigurations_test.go (1 hunks)
• snippet-service/service/http/getAppliedConfigurations_test.go (1 hunks)
• snippet-service/service/service.go (1 hunks)
• snippet-service/service/service_test.go (1 hunks)
• snippet-service/store/condition.go (1 hunks)
• snippet-service/store/configuration.go (1 hunks)

snippet-service/store/configuration.go (11)

9-16: LGTM!

The function correctly validates and normalizes the configuration object.

---

18-23: LGTM!

The ConfigurationVersion type is well-defined.

---

25-35: LGTM!

The Copy method correctly creates a deep copy of a ConfigurationVersion object.

---

37-44: LGTM!

The function correctly maps fields from pb.Configuration to ConfigurationVersion.

---

46-51: LGTM!

The Configuration type is well-defined.

---

53-61: LGTM!

The method correctly initializes the first Configuration object.

---

63-75: LGTM!

The method correctly retrieves and maps the latest pb.Configuration object.

---

77-91: LGTM!

The method correctly iterates over all versions and invokes the callback.

---

93-107: LGTM!

The method correctly creates a deep copy of a Configuration object.

---

109-109: LGTM!

The type alias is correctly defined.

---

111-116: LGTM!

The function correctly validates the InvokeConfigurationRequest object.

snippet-service/store/condition.go (10)

11-18: LGTM!

The function correctly validates and normalizes the condition object.

---

20-30: LGTM!

The ConditionVersion type is well-defined.

---

32-44: LGTM!

The Copy method correctly creates a deep copy of a ConditionVersion object.

---

46-58: LGTM!

The function correctly maps fields from pb.Condition to ConditionVersion.

---

60-66: LGTM!

The Condition type is well-defined.

---

68-77: LGTM!

The method correctly initializes the first Condition object.

---

79-97: LGTM!

The method correctly retrieves and maps the latest pb.Condition object.

---

99-119: LGTM!

The method correctly iterates over all versions and invokes the callback.

---

121-135: LGTM!

The method correctly creates a deep copy of a Condition object.

---

138-144: LGTM!

The function correctly validates and normalizes the conditions query.

snippet-service/service/http/deleteAppliedConfigurations_test.go (1)

27-152: LGTM!

The test comprehensively covers various scenarios for the DeleteAppliedConfigurations endpoint.

snippet-service/service/service.go (5)

35-44: LGTM!

The function correctly creates a store based on the provided configuration.

---

46-64: LGTM!

The function correctly creates a new HTTP service.

---

66-77: LGTM!

The function correctly creates a new gRPC service.

---

79-150: LGTM!

The function correctly initializes and sets up the entire snippet service.

---

152-154: LGTM!

The function correctly returns the store associated with the service.

snippet-service/service/grpc/server.go (1)

49-54: LGTM!

The method correctly maps store errors to gRPC error codes.

snippet-service/service/service_test.go (2)

41-173: Ensure comprehensive test coverage.

The function uses table-driven tests to cover different configurations. Ensure that the test cases cover edge cases and invalid configurations.

---

200-496: Ensure comprehensive test coverage.

The function covers various scenarios for creating, updating, and deleting configurations and conditions. Ensure that the tests cover edge cases and invalid configurations.

Files that changed from the base of the PR and between 0dfa3f3 and ac944ce.

• snippet-service/service/grpc/server.go (1 hunks)

• snippet-service/service/grpc/server.go

Files that changed from the base of the PR and between ac944ce and 96edc2a.

• charts/plgd-hub/templates/m2m-oauth-server/config.yaml is excluded by !**/*.yaml
• charts/plgd-hub/values.yaml is excluded by !**/*.yaml
• m2m-oauth-server/swagger.yaml is excluded by !**/*.yaml

• certificate-authority/service/grpc/signCertificate_test.go (1 hunks)
• m2m-oauth-server/service/config.go (4 hunks)
• m2m-oauth-server/service/token.go (9 hunks)
• m2m-oauth-server/service/token_test.go (6 hunks)
• m2m-oauth-server/test/test.go (4 hunks)
• m2m-oauth-server/uri/uri.go (1 hunks)
• snippet-service/service/grpc/server.go (1 hunks)
• snippet-service/service/http/invokeConfiguration_test.go (1 hunks)
• snippet-service/service/service.go (1 hunks)
• snippet-service/service/service_test.go (1 hunks)
• snippet-service/store/cqldb/appliedConfiguration.go (1 hunks)

• snippet-service/service/grpc/server.go
• snippet-service/service/service.go
• snippet-service/service/service_test.go

m2m-oauth-server/uri/uri.go (1)

16-17: LGTM! Added constant OriginalTokenClaims.

The addition of the constant OriginalTokenClaims looks good.

snippet-service/store/cqldb/appliedConfiguration.go (6)

10-12: LGTM! Added method GetAppliedConfigurations.

The addition of the method GetAppliedConfigurations looks good.

---

14-16: LGTM! Added method DeleteAppliedConfigurations.

The addition of the method DeleteAppliedConfigurations looks good.

---

18-20: LGTM! Added method CreateAppliedConfiguration.

The addition of the method CreateAppliedConfiguration looks good.

---

22-24: LGTM! Added method InsertAppliedConfigurations.

The addition of the method InsertAppliedConfigurations looks good.

---

26-28: LGTM! Added method UpdateAppliedConfigurationResource.

The addition of the method UpdateAppliedConfigurationResource looks good.

---

30-32: LGTM! Added method GetPendingAppliedConfigurationResourceUpdates.

The addition of the method GetPendingAppliedConfigurationResourceUpdates looks good.

m2m-oauth-server/service/token_test.go (1)

20-21: LGTM! Added test case TestGetToken.

The addition of the test case TestGetToken looks good. It covers various scenarios, including valid and invalid tokens, and the new snippetServiceToken.

Also applies to: 41-52, 74-75, 118-120

certificate-authority/service/grpc/signCertificate_test.go (1)

123-130: LGTM! Added test case TestCertificateAuthorityServerSignCSRWithDifferentPublicKeys.

The addition of the test case TestCertificateAuthorityServerSignCSRWithDifferentPublicKeys looks good. It validates the signing of certificates with different public keys and includes configurations for OAuth and CA services.

Also applies to: 133-133

m2m-oauth-server/service/config.go (3)

47-54: LGTM!

The new fields added to the Client struct look good.

---

176-176: LGTM!

The validation logic for the OAuthSignerConfig struct looks good.

---

Line range hint 60-75:
Verify the validation logic.

The validation logic looks correct, but ensure that all necessary fields are being validated appropriately.

m2m-oauth-server/test/test.go (2)

42-42: LGTM!

The new field InsertTokenClaims added to the ServiceOAuthClient looks good.

---

54-54: LGTM!

The new field Authorization added to the JWTPrivateKeyOAuthClient looks good.

m2m-oauth-server/service/token.go (7)

25-27: LGTM!

The new function setKeyErrorExt looks good.

---

62-64: LGTM!

The updates to the makeAccessToken function look good.

---

89-101: LGTM!

The new function setDeviceIDClaim looks good.

---

102-104: LGTM!

The new function setOwnerClaim looks good.

---

150-164: LGTM!

The updates to the tokenRequest struct look good.

---

Line range hint 176-186:
LGTM!

The updates to the postToken function look good.

---

243-243: LGTM!

The updates to the validateClient function look good.

snippet-service/service/http/invokeConfiguration_test.go (4)

40-59: LGTM!

The new function invokeConfiguration looks good.

---

61-95: LGTM!

The new function getPendingCommands looks good.

---

97-322: LGTM!

The new function TestRequestHandlerInvokeConfiguration looks good.

---

324-415: LGTM!

The new function TestParallelRequestHandlerInvokeConfiguration looks good.

Files that changed from the base of the PR and between 96edc2a and 76210c3.

• charts/plgd-hub/values.yaml is excluded by !**/*.yaml

• m2m-oauth-server/test/test.go (1 hunks)
• snippet-service/service/http/invokeConfiguration_test.go (1 hunks)
• snippet-service/service/service.go (1 hunks)
• snippet-service/service/service_test.go (1 hunks)
• snippet-service/store/cqldb/appliedConfiguration.go (1 hunks)
• snippet-service/store/mongodb/appliedConfiguration.go (1 hunks)

• m2m-oauth-server/test/test.go
• snippet-service/service/http/invokeConfiguration_test.go
• snippet-service/service/service.go
• snippet-service/service/service_test.go
• snippet-service/store/cqldb/appliedConfiguration.go

snippet-service/store/mongodb/appliedConfiguration.go (3)

71-98: LGTM!

The function constructs the MongoDB filter correctly.

---

100-119: LGTM!

The function constructs the MongoDB filter correctly.

---

121-131: LGTM!

The function constructs the MongoDB query correctly.